Skip to content

Limit proxy's memory from TiFlash's side (#408)#410

Merged
CalvinNeo merged 6 commits intopingcap:raftstore-proxy-8.1from
ti-chi-bot:cherry-pick-408-to-raftstore-proxy-8.1
Feb 6, 2025
Merged

Limit proxy's memory from TiFlash's side (#408)#410
CalvinNeo merged 6 commits intopingcap:raftstore-proxy-8.1from
ti-chi-bot:cherry-pick-408-to-raftstore-proxy-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 7, 2025 •
edited by CalvinNeo
Loading

This is an automated cherry-pick of #408

What is changed and how it works?

Issue Number: Close tiflash#9745

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix an issue that TiFlash may unexpectedly reject raft message when memory usage is not high

@CalvinNeo @ti-chi-bot
fix
fc04220 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
check config
9193a23 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
fix
69d1633 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
reset memory_usage_high_water
e5d9e80 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
fix tests
3f99be1 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
fix tests 2
20d5a72 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Merged
9 tasks
@CalvinNeo
Copy link
Member

CalvinNeo commented Jan 8, 2025

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 9, 2025

@yudongusa: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 6, 2025

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@CalvinNeo
Copy link
Member

CalvinNeo commented Feb 6, 2025

/approve

@CalvinNeo
Copy link
Member

CalvinNeo commented Feb 6, 2025

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 6, 2025

@CalvinNeo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang, yudongusa

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CalvinNeo CalvinNeo merged commit 7a09c0e into pingcap:raftstore-proxy-8.1 Feb 6, 2025
@ti-chi-bot ti-chi-bot deleted the cherry-pick-408-to-raftstore-proxy-8.1 branch May 27, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

+1 more reviewer

@yudongusa yudongusa yudongusa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CalvinNeo CalvinNeo

Labels

size/L type/cherry-pick-for-raftstore-proxy-8.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @CalvinNeo @JaySon-Huang @yudongusa