Skip to content

Limit proxy's memory from TiFlash's side (#408)#409

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:raftstore-proxy-8.5from
ti-chi-bot:cherry-pick-408-to-raftstore-proxy-8.5
Jan 9, 2025
Merged

Limit proxy's memory from TiFlash's side (#408)#409
ti-chi-bot[bot] merged 6 commits intopingcap:raftstore-proxy-8.5from
ti-chi-bot:cherry-pick-408-to-raftstore-proxy-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 7, 2025 •
edited by CalvinNeo
Loading

This is an automated cherry-pick of #408

What is changed and how it works?

Issue Number: Close tiflash#9745

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix an issue that TiFlash may unexpectedly reject raft message when memory usage is not high

@CalvinNeo @ti-chi-bot
fix
2e03ace 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
check config
b23d49f 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
fix
5ff4c0f 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
reset memory_usage_high_water
0aa1770 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
fix tests
40ee520 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
fix tests 2
00871f1 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Merged
9 tasks
CalvinNeo
CalvinNeo approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 7, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-07 05:09:32.255164339 +0000 UTC m=+243915.543996043: ☑️ agreed by CalvinNeo.

@CalvinNeo
Copy link
Member

CalvinNeo commented Jan 7, 2025

/cc @yudongusa

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

@CalvinNeo: GitHub didn't allow me to request PR reviews from the following users: yudongusa.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @yudongusa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yudongusa
yudongusa approved these changes Jan 9, 2025
View reviewed changes
Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow up on the document.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 9, 2025
@ti-chi-bot ti-chi-bot bot merged commit fdb7f17 into pingcap:raftstore-proxy-8.5 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

+1 more reviewer

@yudongusa yudongusa yudongusa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CalvinNeo CalvinNeo

Labels

approved lgtm size/L type/cherry-pick-for-raftstore-proxy-8.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @CalvinNeo @JaySon-Huang @yudongusa