Decouple engine_store_ffi and raftstore#157
Merged
CalvinNeo merged 5 commits intopingcap:raftstore-proxy-6.2from Sep 5, 2022
Merged
Decouple engine_store_ffi and raftstore#157CalvinNeo merged 5 commits intopingcap:raftstore-proxy-6.2from
CalvinNeo merged 5 commits intopingcap:raftstore-proxy-6.2from
Conversation
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
breezewish
approved these changes
Sep 3, 2022
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
breezewish
reviewed
Sep 5, 2022
Comment on lines
+738
to
+739
| pool: Builder::new(thd_name!("snap-generator")) | ||
| .max_thread_count(snap_generator_pool_size) |
Member
There was a problem hiding this comment.
There is also a "snap_handle_pool_size". Not sure whether this should be used or removed.
Member
Author
There was a problem hiding this comment.
snap_generator_pool_size and snap_handle_pool_size are different configs:
- snap_generator_pool_size is used by TiKV to generate snapshot
- snap_handle_pool_size is used by Proxy to perform row2column work, and is to be decoupled
This was referenced Sep 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: CalvinNeo calvinneo1995@gmail.com
What problem does this PR solve?
Issue Number: ref pingcap/tiflash#5170
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note