Skip to content

Decouple apply snapshot by introducing pre(post)_apply_snapshot#146

Merged
CalvinNeo merged 16 commits intopingcap:raftstore-proxy-6.2from
CalvinNeo:migrate-pre-handle
Aug 31, 2022
Merged

Decouple apply snapshot by introducing pre(post)_apply_snapshot#146
CalvinNeo merged 16 commits intopingcap:raftstore-proxy-6.2from
CalvinNeo:migrate-pre-handle

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Aug 24, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref pingcap/tiflash#5170

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

CalvinNeo and others added 8 commits August 23, 2022 15:36
@CalvinNeo
part restart
c251cd8 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
raftstore: Implement coprocessor observer pre(post)_apply_snapshot (t…
0c95402 
…ikv#12889)

ref tikv#12849

Support new observers pre(post)_apply_snapshot.

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@CalvinNeo
clean_stale_tick_max and clean_stale_check_interval
6cdc6b9 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
add tests
75d1c61 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
remove some TODO(tiflash)
1fd707b 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
remove engine store helper in config part1
6f4279d 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
add tests
111db93 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
refactor tests
d58cfbb 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo force-pushed the migrate-pre-handle branch 15 times, most recently from beeddef to f5da45e Compare August 26, 2022 04:38
@CalvinNeo
address fix
7392cf2 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo mentioned this pull request Aug 26, 2022
Closed
@CalvinNeo
add restart
1e32c1d 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
add test_snap_restart
12c105d 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
address some log problems
17eb204 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
change region_worker_tick_interval
cc12422 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo force-pushed the migrate-pre-handle branch 2 times, most recently from bf7ac7f to 937c6b0 Compare August 31, 2022 08:27
@CalvinNeo
f
7e9b045 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
CalvinNeo
CalvinNeo commented Aug 31, 2022
View reviewed changes
components/raftstore/src/coprocessor/dispatcher.rs Outdated
Copy link
Member Author

@CalvinNeo CalvinNeo Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to cp from tikv

@CalvinNeo
rename clean_stale_tick_max to stale_peer_check_tick
b204603 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo merged commit 6686c34 into pingcap:raftstore-proxy-6.2 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CalvinNeo @breezewish