parser: better error message #133#8950
Merged
jackysp merged 6 commits intopingcap:masterfrom Jan 7, 2019
Merged
Conversation
|
|
zz-jason
reviewed
Jan 5, 2019
Member
|
Looks like we should merge pingcap/parser#133 first, then use the latest "pingcap/parser". |
Signed-off-by: lysu <sulifx@gmail.com>
Contributor
|
/run-all-tests |
Contributor
|
LGTM |
Contributor
|
@tiancaiamao @jackysp PTAL |
Codecov Report
@@ Coverage Diff @@
## master #8950 +/- ##
=========================================
Coverage ? 67.52%
=========================================
Files ? 363
Lines ? 75111
Branches ? 0
=========================================
Hits ? 50719
Misses ? 19914
Partials ? 4478Continue to review full report at Codecov.
|
Member
|
/run-integration-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make parser error/warn message useful.
see pingcap/parser#86
What is changed and how it works?
see https://github.com/pingcap/parser/pull/133/files
Check List
Tests
This change is