Skip to content

expression: do not set ParseToJSONFlag to a JSON column (#8564)#8662

Merged
zz-jason merged 3 commits intopingcap:release-2.0from
XuHuaiyu:release-2.0
Dec 13, 2018
Merged

expression: do not set ParseToJSONFlag to a JSON column (#8564)#8662
zz-jason merged 3 commits intopingcap:release-2.0from
XuHuaiyu:release-2.0

Conversation

@XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Dec 12, 2018

cherry-pick #8564


This change is Reviewable

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 12, 2018
@zhouqiang-cl
Copy link
Contributor

/rebuild

@zhouqiang-cl
Copy link
Contributor

/run-all-tests tidb-test=pr/687 tikv=release-2.0 pd=release-2.0

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests tidb-test=pr/687 tikv=release-2.0 pd=release-2.0

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 01baebc into pingcap:release-2.0 Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants