Skip to content

expression: do not set ParseToJSONFlag to a JSON column (#8564)#8660

Merged
ngaut merged 2 commits intopingcap:release-2.1from
XuHuaiyu:release-2.1
Dec 12, 2018
Merged

expression: do not set ParseToJSONFlag to a JSON column (#8564)#8660
ngaut merged 2 commits intopingcap:release-2.1from
XuHuaiyu:release-2.1

Conversation

@XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Dec 12, 2018

cherry-pick #8564


This change is Reviewable

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. priority/release-blocker This issue blocks a release. Please solve it ASAP. component/expression type/2.1 cherry-pick labels Dec 12, 2018
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 12, 2018
@ngaut ngaut merged commit 47fe9e1 into pingcap:release-2.1 Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants