Skip to content

txn: add tests for shared lock & disable fair lock#65004

Closed
you06 wants to merge 5 commits intopingcap:tidb-8.5-with-shared-lockfrom
you06:8.5-shared-lock/bump-client-go
Closed

txn: add tests for shared lock & disable fair lock#65004
you06 wants to merge 5 commits intopingcap:tidb-8.5-with-shared-lockfrom
you06:8.5-shared-lock/bump-client-go

Conversation

@you06
Copy link
Contributor

@you06 you06 commented Dec 12, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: ref tikv/tikv#19087

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

The default configs are off.

image

The above variables cannot be setting to on as well.

image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@you06
bump client-go & disable fair lock
25f8a8b 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ailinkid, benmeadowcroft for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiprow
Copy link

tiprow bot commented Dec 12, 2025

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

you06 added 2 commits December 15, 2025 19:04
@you06
add lock view tests
33467c6 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
add exec details test for shared lock
0f336bd 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2025
@you06
add tests
6587650 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2025
@you06
add variables validation
7e9f8d3 
Signed-off-by: you06 <you1474600@gmail.com>
@you06 you06 changed the title *: bump client-go & disable fair lock txn: add tests for shared lock & disable fair lock Dec 16, 2025
@you06 you06 mentioned this pull request Dec 19, 2025
Open
13 tasks
@you06 you06 closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@you06