Skip to content

txn: change default settings for shared lock hotfix#64931

Merged
cfzjywxk merged 1 commit intopingcap:tidb-8.5-with-shared-lockfrom
you06:change-default-settings
Dec 10, 2025
Merged

txn: change default settings for shared lock hotfix#64931
cfzjywxk merged 1 commit intopingcap:tidb-8.5-with-shared-lockfrom
you06:change-default-settings

Conversation

@you06
Copy link
Contributor

@you06 you06 commented Dec 9, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: ref tikv/tikv#19087

Problem Summary:

  • Disable 1pc and async commit by default.
  • Enable auto commit pessimistic transaction by default.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Default config has been changed.

MySQL [test]> show variables where Variable_name in ('tidb_enable_async_commit', 'tidb_enable_1pc');
+--------------------------+-------+
| Variable_name            | Value |
+--------------------------+-------+
| tidb_enable_1pc          | OFF   |
| tidb_enable_async_commit | OFF   |
+--------------------------+-------+
2 rows in set (0.006 sec)
image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@you06
change default settings for shared lock hotfix
82e2745 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2025
@tiprow
Copy link

tiprow bot commented Dec 9, 2025

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 9, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cfzjywxk, zyguan
Once this PR has been reviewed and has the lgtm label, please assign yudongusa for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 10, 2025
@cfzjywxk cfzjywxk merged commit 1c439e3 into pingcap:tidb-8.5-with-shared-lock Dec 10, 2025
1 of 2 checks passed
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-09 10:02:32.237063718 +0000 UTC m=+948897.050841290: ☑️ agreed by zyguan.
  • 2025-12-10 04:06:48.489030588 +0000 UTC m=+1013953.302808160: ☑️ agreed by cfzjywxk.

@you06 you06 mentioned this pull request Dec 19, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@zyguan zyguan zyguan approved these changes

Assignees

No one assigned

Labels

lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@you06 @cfzjywxk @zyguan