Skip to content

*: add basic support for shared lock#64432

Merged
cfzjywxk merged 2 commits intopingcap:tidb-8.5-with-shared-lockfrom
zyguan:release-8.5-shared-lock
Dec 4, 2025
Merged

*: add basic support for shared lock#64432
cfzjywxk merged 2 commits intopingcap:tidb-8.5-with-shared-lockfrom
zyguan:release-8.5-shared-lock

Conversation

@zyguan
Copy link
Contributor

@zyguan zyguan commented Nov 12, 2025

What problem does this PR solve?

Issue Number: ref tikv/tikv#19087

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2025
@tiprow
Copy link

tiprow bot commented Nov 12, 2025

Hi @zyguan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zyguan zyguan mentioned this pull request Nov 12, 2025
Open
13 tasks
@zyguan
*: add basic support for shared lock
e849047 
Signed-off-by: zyguan <zhongyangguan@gmail.com>

bump client-go

Signed-off-by: zyguan <zhongyangguan@gmail.com>
@zyguan zyguan force-pushed the release-8.5-shared-lock branch from 9d96922 to e849047 Compare December 3, 2025 05:52
@zyguan zyguan marked this pull request as ready for review December 3, 2025 05:53
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 4, 2025
@you06 you06 requested a review from cfzjywxk December 4, 2025 08:31
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 4, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cfzjywxk, you06
Once this PR has been reviewed and has the lgtm label, please assign benmeadowcroft for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 4, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-04 05:38:44.227583293 +0000 UTC m=+501069.041360865: ☑️ agreed by you06.
  • 2025-12-04 08:49:00.407950231 +0000 UTC m=+512485.221727803: ☑️ agreed by cfzjywxk.

@cfzjywxk cfzjywxk merged commit a6a0d8d into pingcap:tidb-8.5-with-shared-lock Dec 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@you06 you06 you06 approved these changes

Assignees

No one assigned

Labels

lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zyguan @cfzjywxk @you06