Skip to content

binlog: fix the wrong fatal error when binlog is too large (#46365)#60657

Open
ti-chi-bot wants to merge 1 commit intopingcap:release-5.2from
ti-chi-bot:cherry-pick-46365-to-release-5.2
Open

binlog: fix the wrong fatal error when binlog is too large (#46365)#60657
ti-chi-bot wants to merge 1 commit intopingcap:release-5.2from
ti-chi-bot:cherry-pick-46365-to-release-5.2

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46365

What problem does this PR solve?

Issue Number: close #28659

Problem Summary:

What is changed and how it works?

Catch both send and receive large binlog error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. Create a cluster with binlog
  2. Commit a very large delete statement over 2G.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-5.2 labels Apr 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 18, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-5.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants