Skip to content

ddl: check context done in isReorgRunnable function (#57813)#60088

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-7.5from
ti-chi-bot:cherry-pick-57813-to-release-7.5
Closed

ddl: check context done in isReorgRunnable function (#57813)#60088
ti-chi-bot wants to merge 1 commit intopingcap:release-7.5from
ti-chi-bot:cherry-pick-57813-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 14, 2025

This is an automated cherry-pick of #57813

What problem does this PR solve?

Issue Number: close #57325

Problem Summary:

Normally, DXF tasks use isReorgRunnable() to check if a DDL job is canceled. But this function doesn't work correctly after code refactoring in #56404.

What changed and how does it work?

Check if the context is done in isReorgRunnable function.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tangenta @ti-chi-bot
This is an automated cherry-pick of pingcap#57813
ef4cba4 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Mar 14, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2025
Merged
13 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 14, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Mar 14, 2025

@CbcWestwolf This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tangenta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 14, 2025

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 ef4cba4 link true /test check-dev2
idc-jenkins-ci-tidb/unit-test ef4cba4 link true /test unit-test
idc-jenkins-ci-tidb/mysql-test ef4cba4 link true /test mysql-test
idc-jenkins-ci-tidb/build ef4cba4 link true /test build
idc-jenkins-ci-tidb/check_dev ef4cba4 link true /test check-dev

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@CbcWestwolf
Copy link
Member

CbcWestwolf commented Mar 14, 2025

Fix in v7.5.6, close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CbcWestwolf CbcWestwolf

Labels

do-not-merge/cherry-pick-not-approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @CbcWestwolf @tangenta