Skip to content

*: avoid unlock of unlocked mutex panic on TableDeltaMap | tidb-test=920d9bf1b1137cda1272bdd59ae527aee8067944 (#57799)#59666

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5-20241112-v6.5.11from
tiancaiamao:hotifx
Feb 20, 2025
Merged

*: avoid unlock of unlocked mutex panic on TableDeltaMap | tidb-test=920d9bf1b1137cda1272bdd59ae527aee8067944 (#57799)#59666
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5-20241112-v6.5.11from
tiancaiamao:hotifx

Conversation

@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Feb 20, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #57798

Problem Summary:

What changed and how does it work?

cherry-pick #57799

hotfix for 6.5.11

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tiancaiamao tiancaiamao requested a review from a team as a code owner February 20, 2025 06:27
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2025
@tiprow
Copy link

tiprow bot commented Feb 20, 2025

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 20, 2025
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Feb 20, 2025

/test mysql-test

@tiprow
Copy link

tiprow bot commented Feb 20, 2025

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-20 06:33:24.009283944 +0000 UTC m=+1115846.405506004: ☑️ agreed by lcwangchao.
  • 2025-02-20 06:42:41.771239337 +0000 UTC m=+1116404.167461394: ☑️ agreed by ekexium.

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Feb 20, 2025

/test mysql-test

@tiprow
Copy link

tiprow bot commented Feb 20, 2025

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jebter jebter changed the title *: avoid unlock of unlocked mutex panic on TableDeltaMap (#57799) *: avoid unlock of unlocked mutex panic on TableDeltaMap | tidb-test=c1ec4c1217f86e83e4c07da09ef909e3af84ee7e (#57799) Feb 20, 2025
@jebter
Copy link

jebter commented Feb 20, 2025

/test mysql-test

@tiprow
Copy link

tiprow bot commented Feb 20, 2025

@jebter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jebter jebter changed the title *: avoid unlock of unlocked mutex panic on TableDeltaMap | tidb-test=c1ec4c1217f86e83e4c07da09ef909e3af84ee7e (#57799) *: avoid unlock of unlocked mutex panic on TableDeltaMap | tidb-test=920d9bf1b1137cda1272bdd59ae527aee8067944 (#57799) Feb 20, 2025
@jebter
Copy link

jebter commented Feb 20, 2025

/test mysql-test

@tiprow
Copy link

tiprow bot commented Feb 20, 2025

@jebter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5-20241112-v6.5.11@7683911). Learn more about missing BASE report.

Additional details and impacted files 
@@                        Coverage Diff                        @@
##             release-6.5-20241112-v6.5.11     #59666   +/-   ##
=================================================================
  Coverage                                ?   73.6153%           
=================================================================
  Files                                   ?       1097           
  Lines                                   ?     352929           
  Branches                                ?          0           
=================================================================
  Hits                                    ?     259810           
  Misses                                  ?      76393           
  Partials                                ?      16726

@ti-chi-bot ti-chi-bot bot merged commit ae254ca into pingcap:release-6.5-20241112-v6.5.11 Feb 20, 2025
10 checks passed
@tiancaiamao tiancaiamao deleted the hotifx branch February 20, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@ekexium ekexium ekexium approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiancaiamao @jebter @lcwangchao @ekexium