*: avoid unlock of unlocked mutex panic on TableDeltaMap (#57799)#59576
*: avoid unlock of unlocked mutex panic on TableDeltaMap (#57799)#59576ti-chi-bot wants to merge 1 commit intopingcap:release-8.1from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #59576 +/- ##
================================================
Coverage ? 71.2207%
================================================
Files ? 1468
Lines ? 424020
Branches ? 0
================================================
Hits ? 301990
Misses ? 101500
Partials ? 20530
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #57799
What problem does this PR solve?
Issue Number: close #57798
Problem Summary:
What changed and how does it work?
It's most likely that
unlock of unlocked mutexis caused by the struct assignment that overwrite the mutex field.The old code is weird,tdmLockis used to protectTableDeltaMapbut it's not goes together withTableDeltaMap.I wrapTableDeltaMapinto a struct and provideClone()andVisit()function to it.Just tiny workaround!
Check List
Tests
Some kind of data race, not easy to check in the unit test way
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.