Skip to content

global sort: add boundaries to split keys when generating plan (#58323)#58329

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.1from
lance6716:pick8.1-58323
Dec 18, 2024
Merged

global sort: add boundaries to split keys when generating plan (#58323)#58329
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.1from
lance6716:pick8.1-58323

Conversation

@lance6716
Copy link
Contributor

@lance6716 lance6716 commented Dec 17, 2024 •
edited
Loading

This is a manual cherry-pick of #58323

What problem does this PR solve?

Issue Number: close #58267

Problem Summary:

What changed and how does it work?

The data flow of region split keys are long. The requirement of later usage is it must contain the region start/end keys, to correctly pause the PD scheduling of given ranges.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
global sort: add boundaries to split keys when generating plan
b5dbf5f 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
add comment
a1b8027 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
add UT
97dee95 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2024
@tiprow
Copy link

tiprow bot commented Dec 17, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
fix bazel
40c94bf 
Signed-off-by: lance6716 <lance6716@gmail.com>
@codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.86486% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@8a2047e). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.1     #58329   +/-   ##
================================================
  Coverage               ?   71.2080%           
================================================
  Files                  ?       1468           
  Lines                  ?     423743           
  Branches               ?          0           
================================================
  Hits                   ?     301739           
  Misses                 ?     101472           
  Partials               ?      20532
Flag Coverage Δ
unit 71.2080% <64.8648%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.2362% <0.0000%> (?)

@lance6716
Copy link
Contributor Author

lance6716 commented Dec 17, 2024

/retest

@tiprow
Copy link

tiprow bot commented Dec 17, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 17, 2024
@lance6716
Copy link
Contributor Author

lance6716 commented Dec 17, 2024

/retest

@tiprow
Copy link

tiprow bot commented Dec 17, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 17, 2024
Benjamin2037
Benjamin2037 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-17 11:16:33.30714562 +0000 UTC m=+955583.395948158: ☑️ agreed by D3Hunter.
  • 2024-12-18 02:14:40.883472835 +0000 UTC m=+1009470.972275378: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot bot merged commit 61c2172 into pingcap:release-8.1 Dec 18, 2024
@lance6716 lance6716 mentioned this pull request Dec 18, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lance6716 @D3Hunter @Benjamin2037