Skip to content

statistics: get right max table id when to init stats (#58280)#58297

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-58280-to-release-8.1
Dec 16, 2024
Merged

statistics: get right max table id when to init stats (#58280)#58297
ti-chi-bot[bot] merged 3 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-58280-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #58280

What problem does this PR solve?

Issue Number: close #58284
Problem Summary:

What changed and how does it work?

when we get max table id, we should save it into atomic value. but we save common table id into it. so it is bad max table id and lead to other problem .

Image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

get right max table id when to init stats

修复在 init stats 阶段,得到正确的加载范围

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Dec 16, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cherry-pick-approved Cherry pick PR approved by release team. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved labels Dec 16, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei requested a review from AilinKid December 16, 2024 11:10
@codecov
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@13a7da4). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #58297   +/-   ##
================================================
  Coverage               ?   71.2399%           
================================================
  Files                  ?       1468           
  Lines                  ?     423908           
  Branches               ?          0           
================================================
  Hits                   ?     301992           
  Misses                 ?     101434           
  Partials               ?      20482           
Flag Coverage Δ
unit 71.2399% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.2362% <0.0000%> (?)

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-16 10:39:11.210299395 +0000 UTC m=+866941.299101935: ☑️ agreed by hawkingrei.
  • 2024-12-16 15:04:43.714221134 +0000 UTC m=+882873.803023677: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit 8a2047e into pingcap:release-8.1 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants