Skip to content

planner: Use realtimeRowCount when all topN collected (#56848)#58151

Merged
ti-chi-bot[bot] merged 7 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-56848-to-release-8.1
Jul 13, 2025
Merged

planner: Use realtimeRowCount when all topN collected (#56848)#58151
ti-chi-bot[bot] merged 7 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-56848-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 11, 2024

This is an automated cherry-pick of #56848

What problem does this PR solve?

Issue Number: close #47400

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@terry1purcell @ti-chi-bot
This is an automated cherry-pick of pingcap#56848
f1e2021 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Dec 11, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 11, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Dec 11, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 26, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Mar 4, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 21, 2025
fixdb
fixdb reviewed Jul 12, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 13, 2025
terry1purcell
terry1purcell approved these changes Jul 13, 2025
View reviewed changes
Copy link
Contributor

@terry1purcell terry1purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 13, 2025
@codecov
Copy link

codecov bot commented Jul 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@6689f32). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.1     #58151   +/-   ##
================================================
  Coverage               ?   71.2217%           
================================================
  Files                  ?       1469           
  Lines                  ?     424446           
  Branches               ?          0           
================================================
  Hits                   ?     302298           
  Misses                 ?     101593           
  Partials               ?      20555
Flag Coverage Δ
unit 71.2217% <36.3636%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.4188% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@terry1purcell
Copy link
Contributor

terry1purcell commented Jul 13, 2025

/retest-required

@terry1purcell terry1purcell requested a review from fixdb July 13, 2025 02:28
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, terry1purcell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 13, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-13 00:52:26.437874404 +0000 UTC m=+2392999.161053403: ☑️ agreed by terry1purcell.
  • 2025-07-13 07:42:08.369566544 +0000 UTC m=+2417581.092745525: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit df56c9b into pingcap:release-8.1 Jul 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@terry1purcell terry1purcell terry1purcell approved these changes

@fixdb fixdb Awaiting requested review from fixdb

Assignees

@terry1purcell terry1purcell

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @terry1purcell @fixdb @hawkingrei