Skip to content

backup: reset timeout on store level (#55526)#57987

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-8.1from
ti-chi-bot:cherry-pick-55526-to-release-8.1
Closed

backup: reset timeout on store level (#55526)#57987
ti-chi-bot wants to merge 1 commit intopingcap:release-8.1from
ti-chi-bot:cherry-pick-55526-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 4, 2024

This is an automated cherry-pick of #55526

What problem does this PR solve?

Issue Number: close #57666
ref #53480

Problem Summary:
The previous implementation will reset on grpc level. but actually, br could have multiple grpc connections to each store. we only need a timeout on a store level. this PR tried to fix it.

What changed and how does it work?

Reset timeout when receive a backup response from a store.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@3pointer @ti-chi-bot
This is an automated cherry-pick of pingcap#55526
5175dca 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Dec 4, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 4, 2024
Merged
13 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yujuncen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 5175dca link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 5175dca link true /test check-dev2
idc-jenkins-ci-tidb/unit-test 5175dca link true /test unit-test
idc-jenkins-ci-tidb/mysql-test 5175dca link true /test mysql-test
idc-jenkins-ci-tidb/build 5175dca link true /test build

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Dec 13, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 26, 2024
@3pointer 3pointer closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@3pointer 3pointer

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @3pointer