Skip to content

statistics: fix some problem related to stats async load (#57723) (#57774) | tidb-test=2076e2fac85c636e0f3e0f287efc82465f62476a#57946

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-8.1-20241203-v8.1.1from
winoros:pick-to-20241203v8.1
Dec 5, 2024
Merged

statistics: fix some problem related to stats async load (#57723) (#57774) | tidb-test=2076e2fac85c636e0f3e0f287efc82465f62476a#57946
ti-chi-bot[bot] merged 3 commits intopingcap:release-8.1-20241203-v8.1.1from
winoros:pick-to-20241203v8.1

Conversation

@winoros
Copy link
Member

@winoros winoros commented Dec 3, 2024

close #57722, close #57735

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2024
@jebter jebter changed the title statistics: fix some problem related to stats async load (#57723) (#57774) statistics: fix some problem related to stats async load (#57723) (#57774) | tidb-test=2076e2fac85c636e0f3e0f287efc82465f62476a Dec 4, 2024
@jebter
Copy link

jebter commented Dec 4, 2024

/retest

hawkingrei
hawkingrei previously approved these changes Dec 4, 2024
View reviewed changes
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 4, 2024
@jebter
Copy link

jebter commented Dec 4, 2024

/retest

@ti-chi-bot ti-chi-bot bot removed the approved label Dec 4, 2024
@codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.06977% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1-20241203-v8.1.1@a7df4f9). Learn more about missing BASE report.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-8.1-20241203-v8.1.1     #57946   +/-   ##
================================================================
  Coverage                               ?   71.2132%           
================================================================
  Files                                  ?       1466           
  Lines                                  ?     423108           
  Branches                               ?          0           
================================================================
  Hits                                   ?     301309           
  Misses                                 ?     101324           
  Partials                               ?      20475
Flag Coverage Δ
unit 71.2132% <79.0697%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3586% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the approved label Dec 5, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2024

@hawkingrei: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-04 06:10:58.765372676 +0000 UTC m=+1221646.385027191: ☑️ agreed by hawkingrei.
  • 2024-12-05 04:16:25.858954428 +0000 UTC m=+1301173.478608941: ☑️ agreed by time-and-fate.

@jebter
Copy link

jebter commented Dec 5, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6aaadc9 into pingcap:release-8.1-20241203-v8.1.1 Dec 5, 2024
@winoros winoros deleted the pick-to-20241203v8.1 branch December 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@winoros @jebter @hawkingrei @time-and-fate @ti-chi-bot