Skip to content

expression: fix wrong calculation order of radians (#57672)#57687

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-57672-to-release-8.1
Jan 26, 2025
Merged

expression: fix wrong calculation order of radians (#57672)#57687
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-57672-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 25, 2024

This is an automated cherry-pick of #57672

What problem does this PR solve?

Issue Number: close #57671 close #57661

Problem Summary:
See #57671

What changed and how does it work?

radians changes from arg * PI / 180 to arg * (PI / 180) to avoid infinite float and wrong result issues. FYI: https://github.com/mysql/mysql-server/blob/ee079e5ca930ce5ed0643326abadeed8cd41fffc/sql/item_func.h#L1556 MySQL also calculates PI / 180 firstly.
TiKV has already fixed this bug in tikv/tikv#17853.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@gengliqi @ti-chi-bot
fix radian
d84bd5b 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
update integration test result
b786a75 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Nov 25, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2024
Merged
13 tasks
@codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@a55ea35). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.1     #57687   +/-   ##
================================================
  Coverage               ?   71.8258%           
================================================
  Files                  ?       1468           
  Lines                  ?     431817           
  Branches               ?          0           
================================================
  Hits                   ?     310156           
  Misses                 ?     101265           
  Partials               ?      20396
Flag Coverage Δ
unit 71.8258% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.5928% <0.0000%> (?)

yibin87
yibin87 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2024

@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

windtalker
windtalker approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-02 09:33:42.615980781 +0000 UTC m=+1061010.235635294: ☑️ agreed by windtalker.
  • 2024-12-02 09:38:54.701131914 +0000 UTC m=+1061322.320786415: ☑️ agreed by XuHuaiyu.

@gengliqi
Copy link
Contributor

gengliqi commented Dec 2, 2024

/rebuild

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Dec 13, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 26, 2024
@gengliqi
Copy link
Contributor

gengliqi commented Jan 24, 2025

/retest

@gengliqi
Copy link
Contributor

gengliqi commented Jan 24, 2025

/retest

1 similar comment
@gengliqi
Copy link
Contributor

gengliqi commented Jan 26, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit c29e633 into pingcap:release-8.1 Jan 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

+1 more reviewer

@yibin87 yibin87 yibin87 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gengliqi gengliqi

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @gengliqi @windtalker @XuHuaiyu @yibin87