expression: fix wrong calculation order of radians (#57672)#57684
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #57684 +/- ##
================================================
Coverage ? 73.6746%
================================================
Files ? 1097
Lines ? 353272
Branches ? 0
================================================
Hits ? 260272
Misses ? 76273
Partials ? 16727 |
|
@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, wshwsh12, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #57672
What problem does this PR solve?
Issue Number: close #57671 close #57661
Problem Summary:
See #57671
What changed and how does it work?
radians changes from
arg * PI / 180toarg * (PI / 180)to avoid infinite float and wrong result issues. FYI: https://github.com/mysql/mysql-server/blob/ee079e5ca930ce5ed0643326abadeed8cd41fffc/sql/item_func.h#L1556 MySQL also calculatesPI / 180firstly.TiKV has already fixed this bug in tikv/tikv#17853.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.