expression: fix wrong calculation order of radians (#57672)#57682
expression: fix wrong calculation order of radians (#57672)#57682ti-chi-bot wants to merge 1 commit intopingcap:release-5.4from
radians (#57672)#57682Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #57672
What problem does this PR solve?
Issue Number: close #57671 close #57661
Problem Summary:
See #57671
What changed and how does it work?
radians changes from
arg * PI / 180toarg * (PI / 180)to avoid infinite float and wrong result issues. FYI: https://github.com/mysql/mysql-server/blob/ee079e5ca930ce5ed0643326abadeed8cd41fffc/sql/item_func.h#L1556 MySQL also calculatesPI / 180firstly.TiKV has already fixed this bug in tikv/tikv#17853.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.