Skip to content

util: add tiflash wait time in execution summary (#57058)#57371

Merged
ti-chi-bot[bot] merged 8 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-57058-to-release-8.5
Nov 14, 2024
Merged

util: add tiflash wait time in execution summary (#57058)#57371
ti-chi-bot[bot] merged 8 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-57058-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 14, 2024

This is an automated cherry-pick of #57058

What problem does this PR solve?

Issue Number: close #57059 ref pingcap/tiflash#9489

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

yibin added 8 commits November 14, 2024 03:29
@ti-chi-bot
Add tiflash wait summary related logic
6a4be70 
Signed-off-by: yibin <huyibin@pingcap.cn>
@ti-chi-bot
Add dump logic
c8d9a21 
Signed-off-by: yibin <huyibin@pingcap.cn>
@ti-chi-bot
update bazel file
04274ae 
Signed-off-by: yibin <huyibin@pingcap.cn>
@ti-chi-bot
Fix compilation issue
07e70ae 
Signed-off-by: yibin <huyibin@pingcap.cn>
@ti-chi-bot
Add unit test
8988907 
Signed-off-by: yibin <huyibin@pingcap.cn>
@ti-chi-bot
Fix lint issue
845e544 
Signed-off-by: yibin <huyibin@pingcap.cn>
@ti-chi-bot
A little refact for display format
3a155ae 
Signed-off-by: yibin <huyibin@pingcap.cn>
@ti-chi-bot
Address comments
69303ca 
Signed-off-by: yibin <huyibin@pingcap.cn>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-57058-to-release-8.5 branch from 7044afc to 69303ca Compare November 14, 2024 03:29
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 14, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2024
Merged
13 tasks
@codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.16667% with 15 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@0db50c1). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.5     #57371   +/-   ##
================================================
  Coverage               ?   56.4999%           
================================================
  Files                  ?       1780           
  Lines                  ?     635587           
  Branches               ?          0           
================================================
  Hits                   ?     359106           
  Misses                 ?     252241           
  Partials               ?      24240
Flag Coverage Δ
integration 37.2190% <29.1666%> (?)
unit 72.6334% <79.1666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.6015% <0.0000%> (?)

@yibin87
Copy link
Contributor

yibin87 commented Nov 14, 2024

/cc @windtalker

@ti-chi-bot ti-chi-bot bot requested a review from windtalker November 14, 2024 05:00
windtalker
windtalker approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
yibin87
yibin87 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-14 05:09:32.044602685 +0000 UTC m=+505734.235471674: ☑️ agreed by windtalker.
  • 2024-11-14 05:55:03.672992133 +0000 UTC m=+508465.863861130: ☑️ agreed by yibin87.

@yibin87
Copy link
Contributor

yibin87 commented Nov 14, 2024

/test check-dev2

@tiprow
Copy link

tiprow bot commented Nov 14, 2024

@yibin87: No presubmit jobs available for pingcap/tidb@release-8.5

Details

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit f485d63 into pingcap:release-8.5 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+1 more reviewer

@yibin87 yibin87 yibin87 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yibin87 yibin87

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @yibin87 @windtalker