statistics: refine comments to FMSketch#53601
Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom May 28, 2024
Merged
statistics: refine comments to FMSketch#53601ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
Conversation
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
0xPoe
commented
May 28, 2024
Member
Author
0xPoe
left a comment
There was a problem hiding this comment.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
hawkingrei
reviewed
May 28, 2024
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53601 +/- ##
================================================
+ Coverage 72.4916% 74.8615% +2.3699%
================================================
Files 1506 1507 +1
Lines 430600 434617 +4017
================================================
+ Hits 312149 325361 +13212
+ Misses 99229 89253 -9976
- Partials 19222 20003 +781
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hawkingrei
approved these changes
May 28, 2024
[LGTM Timeline notifier]Timeline:
|
Member
|
/ok-to-test |
Member
|
/hold |
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
704fc58 to
4866fcf
Compare
time-and-fate
approved these changes
May 28, 2024
Member
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, elsa0520, hawkingrei, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
9 tasks
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close None
Problem Summary:
What changed and how does it work?
I have made the necessary corrections to the comments for FMSketch. Although we refer to it as FMSketch, it is actually a variant of FMSketch. The concept is quite similar, but the implementation differs significantly. Therefore, we need to update the comment to avoid confusion.
Some more links:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.