Skip to content

expression: Reverts pingcap/tidb#53207 (release-8.1) | tidb-test=pr/2330#53260

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-8.1from
ti-chi-bot:revert-53207-cherry-pick-53129-to-release-8.1
May 14, 2024
Merged

expression: Reverts pingcap/tidb#53207 (release-8.1) | tidb-test=pr/2330#53260
ti-chi-bot[bot] merged 1 commit intopingcap:release-8.1from
ti-chi-bot:revert-53207-cherry-pick-53129-to-release-8.1

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented May 14, 2024 •
edited
Loading

Reverts #53207

What problem does this PR solve?

Issue Number: close #53248

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2024
@tiprow
Copy link

tiprow bot commented May 14, 2024

Hi @solotzg. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 14, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 14, 2024
@solotzg solotzg changed the title expression: Reverts pingcap/tidb#53207 | tidb-test=pr/2330 expression: Reverts pingcap/tidb#53207 (release-8.1) | tidb-test=pr/2330 May 14, 2024
yibin87
yibin87 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2024

@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-14 09:47:37.218893264 +0000 UTC m=+1560210.976028838: ☑️ agreed by XuHuaiyu.
  • 2024-05-14 09:52:33.37767099 +0000 UTC m=+1560507.134806639: ☑️ agreed by guo-shaoge.

@codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-8.1@e30e05e). Click here to learn what that means.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.1     #53260   +/-   ##
================================================
  Coverage               ?   71.1424%           
================================================
  Files                  ?       1465           
  Lines                  ?     421200           
  Branches               ?          0           
================================================
  Hits                   ?     299652           
  Misses                 ?     101061           
  Partials               ?      20487
Flag Coverage Δ
unit 71.1424% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9772% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 3292ed1 into pingcap:release-8.1 May 14, 2024
@solotzg solotzg deleted the revert-53207-cherry-pick-53129-to-release-8.1 branch May 14, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

+1 more reviewer

@yibin87 yibin87 yibin87 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@solotzg @guo-shaoge @XuHuaiyu @yibin87 @ti-chi-bot