Skip to content

backup: advacned prepare implementation (#48439)#52569

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-7.5from
ti-chi-bot:cherry-pick-48439-to-release-7.5
Closed

backup: advacned prepare implementation (#48439)#52569
ti-chi-bot wants to merge 1 commit intopingcap:release-7.5from
ti-chi-bot:cherry-pick-48439-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 12, 2024

This is an automated cherry-pick of #48439

What problem does this PR solve?

Issue Number: close #50359

Problem Summary:
This PR implemented the client side of the enhanced prepare stage of snapshot backup.

What is changed and how it works?

Generally this is a state machine that tries to collect the whole range. If a region has applied to the last index, the region's range will be collected. When the whole key space has been collected, we are done.

Check List

Tests

  • Unit test (TBD)
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@YuJuncen @ti-chi-bot
This is an automated cherry-pick of pingcap#48439
49dc8b1 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Apr 12, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 12, 2024
Merged
13 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 12, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign leavrth for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 12, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 49dc8b1 link true /test mysql-test
idc-jenkins-ci-tidb/build 49dc8b1 link true /test build
idc-jenkins-ci-tidb/check_dev_2 49dc8b1 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 49dc8b1 link true /test check-dev
idc-jenkins-ci-tidb/unit-test 49dc8b1 link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nkg-
Copy link
Contributor

nkg- commented Apr 29, 2024

@YuJuncen : Whats pending here. We are testing EBS BR on 7.5, so this is a critical PR for it.

@YuJuncen YuJuncen closed this May 6, 2024
@YuJuncen
Copy link
Contributor

YuJuncen commented Dec 2, 2024

(This should have be brought to release-7.5 with another cherry-pick PR.)

@YuJuncen
Copy link
Contributor

YuJuncen commented Dec 2, 2024

(it should be #50443)

@ti-chi-bot ti-chi-bot deleted the cherry-pick-48439-to-release-7.5 branch April 15, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@YuJuncen YuJuncen

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @nkg- @YuJuncen