Skip to content

sessionctx,executor: support div_precision_increment sysvar | tidb-test=pr/2311#51538

Merged
ti-chi-bot[bot] merged 20 commits intopingcap:masterfrom
yibin87:div_increase_prec
Mar 14, 2024
Merged

sessionctx,executor: support div_precision_increment sysvar | tidb-test=pr/2311#51538
ti-chi-bot[bot] merged 20 commits intopingcap:masterfrom
yibin87:div_increase_prec

Conversation

@yibin87
Copy link
Contributor

@yibin87 yibin87 commented Mar 6, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #51501

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

yibin87 added 2 commits March 6, 2024 14:42
@yibin87
Add sysvar related logic
8d43138 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Update type infer and evaluation logic to use DivPrecisionIncrement s…
00eb716 
…ys var

Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2024
@tiprow
Copy link

tiprow bot commented Mar 6, 2024

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Temporary changes
b3ee183 
Signed-off-by: yibin <huyibin@pingcap.com>
@codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Merging #51538 (48c8145) into master (dbdae85) will increase coverage by 2.2089%.
Report is 4 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #51538        +/-   ##
================================================
+ Coverage   70.7379%   72.9468%   +2.2089%     
================================================
  Files          1476       1476                
  Lines        437399     443926      +6527     
================================================
+ Hits         309407     323830     +14423     
+ Misses       108615      99971      -8644     
- Partials      19377      20125       +748
Flag Coverage Δ
integration 49.0321% <82.5000%> (?)
unit 70.5344% <100.0000%> (-0.0179%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4970% <ø> (+5.5809%) ⬆️

yibin87 added 5 commits March 6, 2024 16:36
@yibin87
Revert back
bb15cfc 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Revert hard code
178d5c3 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Add back test contents
b235bac 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
add dagReq set logic and mock cop handler logic
dbf7158 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
update bazel files
83ae418 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 yibin87 changed the title [WIP]executor: support div_precision_increment sysvar sessionctx,executor: support div_precision_increment sysvar Mar 7, 2024
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Mar 7, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 7, 2024

/test build

@tiprow
Copy link

tiprow bot commented Mar 7, 2024

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 7, 2024

/test build

@tiprow
Copy link

tiprow bot commented Mar 7, 2024

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

hawkingrei commented Mar 7, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 7, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 7, 2024

/test build

@tiprow
Copy link

tiprow bot commented Mar 7, 2024

@yibin87: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yibin87 added 3 commits March 7, 2024 13:21
@yibin87
Fix bazel issue
75fba70 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Little update
87735fb 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Fix format issue
60ecc01 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 7, 2024

/cc @windtalker @SeaRise

@ti-chi-bot ti-chi-bot bot requested review from SeaRise and windtalker March 7, 2024 07:33
@yibin87
update unit test
373c016 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 8, 2024
windtalker
windtalker approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 11, 2024

/hold

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 11, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-08 02:30:24.124005796 +0000 UTC m=+393451.146252181: ☑️ agreed by SeaRise.
  • 2024-03-11 01:23:16.513680449 +0000 UTC m=+648623.535926837: ☑️ agreed by windtalker.

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 14, 2024

/cc @easonn7

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 14, 2024

@yibin87: GitHub didn't allow me to request PR reviews from the following users: easonn7.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @easonn7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@easonn7
Copy link

easonn7 commented Mar 14, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 14, 2024
@yibin87 yibin87 changed the title sessionctx,executor: support div_precision_increment sysvar sessionctx,executor: support div_precision_increment sysvar | tidb-test=pr/2311 Mar 14, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 14, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 14, 2024

/test check-dev

@tiprow
Copy link

tiprow bot commented Mar 14, 2024

@yibin87: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 14, 2024

/test check-dev2

@tiprow
Copy link

tiprow bot commented Mar 14, 2024

@yibin87: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 14, 2024

/test unit-test

@tiprow
Copy link

tiprow bot commented Mar 14, 2024

@yibin87: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit ef30a69 into pingcap:master Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+1 more reviewer

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support div_precision_increment sysvar in tidb

5 participants

@yibin87 @hawkingrei @easonn7 @windtalker @SeaRise