types: add overflow truncate when convert str to float#5130
Merged
winoros merged 3 commits intopingcap:masterfrom Nov 22, 2017
Merged
types: add overflow truncate when convert str to float#5130winoros merged 3 commits intopingcap:masterfrom
winoros merged 3 commits intopingcap:masterfrom
Conversation
Contributor
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
Member
|
@mccxj Thanks! |
Contributor
Author
|
@winoros PTAL. |
Member
|
/run-all-tests |
Member
|
/run-integration-ddl-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #5111 . @winoros PTAL.