Skip to content

planner: fix the issue that TIDB_INLJ hint cannot take effect when left joining two sub-queries (#46271)#50910

Closed
ti-chi-bot wants to merge 2 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-46271-to-release-7.5
Closed

planner: fix the issue that TIDB_INLJ hint cannot take effect when left joining two sub-queries (#46271)#50910
ti-chi-bot wants to merge 2 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-46271-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 1, 2024

This is an automated cherry-pick of #46271

What problem does this PR solve?

Issue Number: close #46160

Problem Summary: planner: fix the issue that TIDB_INLJ hint cannot take effect when left joining two sub-queries

What is changed and how it works?

planner: fix the issue that TIDB_INLJ hint cannot take effect when left joining two sub-queries

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 1, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 1, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2024
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#46271
6acafa9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-46271-to-release-7.5 branch from 3fd96c7 to 6acafa9 Compare February 1, 2024 10:59
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qw4990. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AilinKid
AilinKid reviewed Feb 3, 2024
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 6acafa9 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 6acafa9 link true /test check-dev2
idc-jenkins-ci-tidb/unit-test 2131ad8 link true /test unit-test
idc-jenkins-ci-tidb/build 2131ad8 link true /test build

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qw4990
Copy link
Contributor

qw4990 commented Feb 19, 2024

This PR has already been in v7.5

@qw4990 qw4990 closed this Feb 19, 2024
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 19, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot deleted the cherry-pick-46271-to-release-7.5 branch April 15, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AilinKid AilinKid AilinKid left review comments

Assignees

@qw4990 qw4990

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @qw4990 @AilinKid