Skip to content

ddl, parser: make generated column and expression index same as MySQL (#39888)#50714

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-39888-to-release-6.5
Sep 12, 2024
Merged

ddl, parser: make generated column and expression index same as MySQL (#39888)#50714
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-39888-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 25, 2024

This is an automated cherry-pick of #39888

What problem does this PR solve?

Issue Number: close #39826

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Defined2014 @ti-chi-bot
This is an automated cherry-pick of pingcap#39888
2717421 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 25, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 25, 2024
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 25, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 reopened this Sep 12, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 12, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 12, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 12, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-12 06:41:41.990841067 +0000 UTC m=+511371.731265006: ☑️ agreed by Defined2014.
  • 2024-09-12 06:44:15.445894141 +0000 UTC m=+511525.186318100: ☑️ agreed by tiancaiamao.

@Defined2014
Copy link
Contributor

Defined2014 commented Sep 12, 2024

/retest

@codecov
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5@1e7b160). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #50714   +/-   ##
================================================
  Coverage               ?   73.6415%           
================================================
  Files                  ?       1097           
  Lines                  ?     352881           
  Branches               ?          0           
================================================
  Hits                   ?     259867           
  Misses                 ?      76306           
  Partials               ?      16708

@ti-chi-bot ti-chi-bot bot merged commit 337f4a0 into pingcap:release-6.5 Sep 12, 2024
@Defined2014 Defined2014 deleted the cherry-pick-39888-to-release-6.5 branch September 12, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees

@Defined2014 Defined2014

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @Defined2014 @tiancaiamao