Skip to content

planner: fix leading hint cannot take effect in UNION ALL statements (#50277)#50376

Closed
ti-chi-bot wants to merge 4 commits intopingcap:release-7.6from
ti-chi-bot:cherry-pick-50277-to-release-7.6
Closed

planner: fix leading hint cannot take effect in UNION ALL statements (#50277)#50376
ti-chi-bot wants to merge 4 commits intopingcap:release-7.6from
ti-chi-bot:cherry-pick-50277-to-release-7.6

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50277

What problem does this PR solve?

Issue Number: close #50067

Problem Summary:

What changed and how does it work?

the root cause is that the PlanBuilder.tableHintInfo will be overwritten by push/pop in the buildSelect

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 12, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-12 09:08:38.277814184 +0000 UTC m=+607107.862067871: ☑️ agreed by hawkingrei.

@hawkingrei hawkingrei closed this Jan 12, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants