Skip to content

planner: plan cache supports Batch/PointGet converted from (primary keys) in ((...), ...) (#44838) #49735

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5-20230706-v6.5.3from
qw4990:44838-pick
Dec 22, 2023
Merged

planner: plan cache supports Batch/PointGet converted from (primary keys) in ((...), ...) (#44838) #49735
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5-20230706-v6.5.3from
qw4990:44838-pick

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Dec 22, 2023

This is an automated cherry-pick of #44838

What problem does this PR solve?

Issue Number: close #44830

Problem Summary: planner: plan cache supports Batch/PointGet converted from (primary keys) in ((...), ...)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 requested a review from a team as a code owner December 22, 2023 16:09
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2023
@tiprow
Copy link

tiprow bot commented Dec 22, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 22, 2023
@codecov
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20230706-v6.5.3@ad0e8d2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-6.5-20230706-v6.5.3     #49735   +/-   ##
================================================================
  Coverage                               ?   73.4308%           
================================================================
  Files                                  ?       1080           
  Lines                                  ?     346612           
  Branches                               ?          0           
================================================================
  Hits                                   ?     254520           
  Misses                                 ?      75640           
  Partials                               ?      16452

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackysp, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 16:11:08.270143793 +0000 UTC m=+1236559.307370713: ☑️ agreed by winoros.
  • 2023-12-22 23:57:35.658342445 +0000 UTC m=+1264546.695569357: ☑️ agreed by jackysp.

@ti-chi-bot ti-chi-bot bot merged commit bef2414 into pingcap:release-6.5-20230706-v6.5.3 Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackysp jackysp jackysp approved these changes

@winoros winoros winoros approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qw4990 @jackysp @winoros