Skip to content

expression: enum/set could be invalid during evaluation (#49543)#49551

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-49543-to-release-7.5
Feb 9, 2024
Merged

expression: enum/set could be invalid during evaluation (#49543)#49551
ti-chi-bot[bot] merged 4 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-49543-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 18, 2023

This is an automated cherry-pick of #49543

What problem does this PR solve?

Issue Number: close #49487

Problem Summary:

What changed and how does it work?

The invalid enum/set value can exist during evaluation. So we should not throw error here.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#49543
e031962 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 18, 2023
Merged
13 tasks
@codecov
Copy link

codecov bot commented Dec 27, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@b2d3fb9). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.5     #49551   +/-   ##
================================================
  Coverage               ?   72.0775%           
================================================
  Files                  ?       1403           
  Lines                  ?     408489           
  Branches               ?          0           
================================================
  Hits                   ?     294429           
  Misses                 ?      94367           
  Partials               ?      19693
Flag Coverage Δ
unit 72.0775% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.1714% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 1, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 1, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-01 13:21:21.372183002 +0000 UTC m=+1658122.936480692: ☑️ agreed by hawkingrei.
  • 2024-02-01 13:34:49.425914289 +0000 UTC m=+1658930.990211992: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 3, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 7, 2024
@winoros
Copy link
Member

winoros commented Feb 9, 2024

/retest

@winoros winoros removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2f2de41 into pingcap:release-7.5 Feb 9, 2024
@ti-chi-bot ti-chi-bot deleted the cherry-pick-49543-to-release-7.5 branch April 15, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@winoros winoros winoros approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees

@winoros winoros

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @winoros @hawkingrei @XuHuaiyu