Skip to content

expression: enum/set could be invalid during evaluation (#49543)#49549

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-49543-to-release-6.5
Dec 22, 2023
Merged

expression: enum/set could be invalid during evaluation (#49543)#49549
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-49543-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 18, 2023

This is an automated cherry-pick of #49543

What problem does this PR solve?

Issue Number: close #49487

Problem Summary:

What changed and how does it work?

The invalid enum/set value can exist during evaluation. So we should not throw error here.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#49543
2a933ae 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 18, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 22, 2023
@qw4990
Copy link
Contributor

qw4990 commented Dec 22, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Dec 22, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 06:17:28.166533355 +0000 UTC m=+1200939.203760281: ☑️ agreed by qw4990.
  • 2023-12-22 06:35:21.355742924 +0000 UTC m=+1202012.392969850: ☑️ agreed by AilinKid.

@qw4990
Copy link
Contributor

qw4990 commented Dec 22, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Dec 22, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Dec 22, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Dec 22, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@10caef0). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #49549   +/-   ##
================================================
  Coverage               ?   73.6727%           
================================================
  Files                  ?       1087           
  Lines                  ?     349645           
  Branches               ?          0           
================================================
  Hits                   ?     257593           
  Misses                 ?      75517           
  Partials               ?      16535

@ti-chi-bot ti-chi-bot bot merged commit 899b511 into pingcap:release-6.5 Dec 22, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-49543-to-release-6.5 branch April 15, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees

@winoros winoros

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @qw4990 @AilinKid @winoros