Skip to content

session: fix select for update statement can't get stmt-count-limit error (#48412)#49512

Merged
ti-chi-bot merged 2 commits intopingcap:release-4.0-20231215-v4.0.12from
crazycs520:release-4.0-20231215-48412
Dec 17, 2023
Merged

session: fix select for update statement can't get stmt-count-limit error (#48412)#49512
ti-chi-bot merged 2 commits intopingcap:release-4.0-20231215-v4.0.12from
crazycs520:release-4.0-20231215-48412

Conversation

@crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Dec 15, 2023

This is an automated cherry-pick of #48412

What problem does this PR solve?

Issue Number: close #48411

Problem Summary: fix select for update statement can't got stmt-count-limit error

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix issue of select for update statement can't get stmt-count-limit error

@crazycs520
session: fix select for update statement can't get stmt-count-limit e…
0e3f93a 
…rror (pingcap#48412)

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 15, 2023
@tiprow
Copy link

tiprow bot commented Dec 15, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 16, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-16 05:51:33.077848273 +0000 UTC m=+680984.115075186: ☑️ agreed by cfzjywxk.
  • 2023-12-16 06:03:44.845294135 +0000 UTC m=+681715.882521062: ☑️ agreed by zyguan.

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Dec 16, 2023

/retest

@tiprow
Copy link

tiprow bot commented Dec 16, 2023

@cfzjywxk: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Dec 16, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 16, 2023
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Dec 16, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2023

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2023

@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, wuhuizuo, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wuhuizuo
Update Makefile
3a2b402 
fix ref tool version for  honnef.co/go/tools

we need limit it to `2021.1` version to support go1.13
@ti-chi-bot ti-chi-bot merged commit f172580 into pingcap:release-4.0-20231215-v4.0.12 Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wuhuizuo wuhuizuo wuhuizuo approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@zyguan zyguan zyguan approved these changes

Assignees

No one assigned

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crazycs520 @cfzjywxk @wuhuizuo @zyguan @ti-chi-bot