Skip to content

executor: set OverflowAsWarning for insert statement in non-strict sql mode (#49383)#49484

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.1-20231215-v7.1.1from
tiancaiamao:hotfix1
Dec 15, 2023
Merged

executor: set OverflowAsWarning for insert statement in non-strict sql mode (#49383)#49484
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.1-20231215-v7.1.1from
tiancaiamao:hotfix1

Conversation

@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Dec 15, 2023

What problem does this PR solve?

Issue Number: close #49369

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tiancaiamao
This is an automated cherry-pick of pingcap#49383
8186aca 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@tiancaiamao
resolve conflict
29f0136
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2023
@tiprow
Copy link

tiprow bot commented Dec 15, 2023

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 15, 2023
@codecov
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1-20231215-v7.1.1@ac248c1). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-7.1-20231215-v7.1.1     #49484   +/-   ##
================================================================
  Coverage                               ?   73.4331%           
================================================================
  Files                                  ?       1202           
  Lines                                  ?     376206           
  Branches                               ?          0           
================================================================
  Hits                                   ?     276260           
  Misses                                 ?      82312           
  Partials                               ?      17634

bb7133
bb7133 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-15 02:34:32.827847991 +0000 UTC m=+582763.865074911: ☑️ agreed by YangKeao.
  • 2023-12-15 04:14:00.042574804 +0000 UTC m=+588731.079801730: ☑️ agreed by bb7133.

@ti-chi-bot ti-chi-bot bot merged commit b57f662 into pingcap:release-7.1-20231215-v7.1.1 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiancaiamao @bb7133 @YangKeao