Skip to content

executor: set OverflowAsWarning for insert statement in non-strict sql mode (#49383)#49456

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-5.4from
ti-chi-bot:cherry-pick-49383-to-release-5.4
Closed

executor: set OverflowAsWarning for insert statement in non-strict sql mode (#49383)#49456
ti-chi-bot wants to merge 1 commit intopingcap:release-5.4from
ti-chi-bot:cherry-pick-49383-to-release-5.4

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 14, 2023

This is an automated cherry-pick of #49383

What problem does this PR solve?

Issue Number: close #49369

Problem Summary:

What changed and how does it work?

Fix the compatibility issue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

In non-strict SQL mode, treat the overflow error as warning in insert statement.

@tiancaiamao @ti-chi-bot
This is an automated cherry-pick of pingcap#49383
655ea6d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 14, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Dec 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wshwsh12 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 14, 2023

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2023
@ti-chi-bot ti-chi-bot closed this Feb 17, 2025
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 17, 2025

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

@ti-chi-bot ti-chi-bot deleted the cherry-pick-49383-to-release-5.4 branch April 15, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tiancaiamao tiancaiamao

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @tiancaiamao