Skip to content

executor: set OverflowAsWarning for insert statement in non-strict sql mode (#49383)#49455

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-49383-to-release-7.5
Feb 20, 2024
Merged

executor: set OverflowAsWarning for insert statement in non-strict sql mode (#49383)#49455
ti-chi-bot[bot] merged 5 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-49383-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 14, 2023

This is an automated cherry-pick of #49383

What problem does this PR solve?

Issue Number: close #49369

Problem Summary:

What changed and how does it work?

Fix the compatibility issue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

In non-strict SQL mode, treat the overflow error as warning in insert statement.

@tiancaiamao @ti-chi-bot
This is an automated cherry-pick of pingcap#49383
5b28c47 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 14, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2023
@codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@53b15c5). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.5     #49455   +/-   ##
================================================
  Coverage               ?   72.4949%           
================================================
  Files                  ?       1404           
  Lines                  ?     410902           
  Branches               ?          0           
================================================
  Hits                   ?     297883           
  Misses                 ?      93419           
  Partials               ?      19600
Flag Coverage Δ
unit 72.4949% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3101% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 6, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2024
@tiancaiamao
Copy link
Contributor

tiancaiamao commented Feb 20, 2024

/test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

@tiancaiamao: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-7.5/ghpr_build
  • pingcap/tidb/release-7.5/ghpr_check
  • pingcap/tidb/release-7.5/ghpr_check2
  • pingcap/tidb/release-7.5/ghpr_mysql_test
  • pingcap/tidb/release-7.5/ghpr_unit_test
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiancaiamao
Copy link
Contributor

tiancaiamao commented Feb 20, 2024

/test check_dev_2

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-7.5/ghpr_build
  • pingcap/tidb/release-7.5/ghpr_check
  • pingcap/tidb/release-7.5/ghpr_check2
  • pingcap/tidb/release-7.5/ghpr_mysql_test
  • pingcap/tidb/release-7.5/ghpr_unit_test
Details

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Feb 20, 2024

@tiancaiamao: No presubmit jobs available for pingcap/tidb@release-7.5

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiancaiamao
Copy link
Contributor

tiancaiamao commented Feb 20, 2024

/test check-dev2

@tiprow
Copy link

tiprow bot commented Feb 20, 2024

@tiancaiamao: No presubmit jobs available for pingcap/tidb@release-7.5

Details

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Feb 20, 2024

@tiancaiamao: No presubmit jobs available for pingcap/tidb@release-7.5

Details

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

YangKeao
YangKeao approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the approved label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 20, 2024
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,YangKeao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-20 05:35:23.097675407 +0000 UTC m=+335411.845298531: ☑️ agreed by YangKeao.
  • 2024-02-20 07:42:25.593908706 +0000 UTC m=+343034.341531913: ☑️ agreed by Defined2014.

@tiancaiamao
Copy link
Contributor

tiancaiamao commented Feb 20, 2024

/test mysql-test

@tiprow
Copy link

tiprow bot commented Feb 20, 2024

@tiancaiamao: No presubmit jobs available for pingcap/tidb@release-7.5

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit af141d5 into pingcap:release-7.5 Feb 20, 2024
@ti-chi-bot ti-chi-bot deleted the cherry-pick-49383-to-release-7.5 branch April 15, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YangKeao YangKeao YangKeao approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees

@tiancaiamao tiancaiamao

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @tiancaiamao @YangKeao @Defined2014