Skip to content

executor: fix index out of range panic of cte when max_chunk_size is samll (#48839)#49005

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-48839-to-release-7.5
Dec 7, 2023
Merged

executor: fix index out of range panic of cte when max_chunk_size is samll (#48839)#49005
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-48839-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 29, 2023

This is an automated cherry-pick of #48839

What problem does this PR solve?

Issue Number: close #48808

Problem Summary:

  1. CTEExec assume result chunk of child operator will not exceed max_chunk_size. Check builder
  2. Actually row num of chunk will exceeds MaxChunkSize sometimes. Check reuse chunk
  3. So CTEExec may panic here

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#48839
4d98817 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 29, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 29, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 4, 2023
@guo-shaoge
fix case
f555c35 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-04 08:10:03.862912875 +0000 UTC m=+1428632.528139070: ☑️ agreed by wshwsh12.
  • 2023-12-04 08:35:02.444243388 +0000 UTC m=+1430131.109469585: ☑️ agreed by Defined2014.

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Dec 4, 2023

/run-unit-test

1 similar comment
@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Dec 5, 2023

/run-unit-test

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Dec 5, 2023

/retest

2 similar comments
@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Dec 6, 2023

/retest

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Dec 7, 2023

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 7, 2023
@codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@069631e). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.5     #49005   +/-   ##
================================================
  Coverage               ?   71.9837%           
================================================
  Files                  ?       1399           
  Lines                  ?     406342           
  Branches               ?          0           
================================================
  Hits                   ?     292500           
  Misses                 ?      94163           
  Partials               ?      19679
Flag Coverage Δ
unit 71.9837% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2571% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 37e005f into pingcap:release-7.5 Dec 7, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-48839-to-release-7.5 branch April 15, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees

@guo-shaoge guo-shaoge

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @guo-shaoge @wshwsh12 @Defined2014