Skip to content

planner: fix nil pointer at expression.(*CorrelatedColumn).Eval (#42789)#48974

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-5.4from
ti-chi-bot:cherry-pick-42789-to-release-5.4
Nov 29, 2023
Merged

planner: fix nil pointer at expression.(*CorrelatedColumn).Eval (#42789)#48974
ti-chi-bot[bot] merged 2 commits intopingcap:release-5.4from
ti-chi-bot:cherry-pick-42789-to-release-5.4

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 28, 2023

This is an automated cherry-pick of #42789

What problem does this PR solve?

Issue Number: close #42739

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@CbcWestwolf @ti-chi-bot
This is an automated cherry-pick of pingcap#42789
8b2a77c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Nov 28, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 28, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 29, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 29, 2023

@fzzf678: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CbcWestwolf
Copy link
Member

CbcWestwolf commented Nov 29, 2023

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 29, 2023

@CbcWestwolf: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, fzzf678, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-29 01:58:33.819240637 +0000 UTC m=+974342.484466827: ☑️ agreed by CbcWestwolf.
  • 2023-11-29 09:42:30.169315475 +0000 UTC m=+1002178.834541670: ☑️ agreed by lcwangchao.

@ti-chi-bot ti-chi-bot bot merged commit 9c074a2 into pingcap:release-5.4 Nov 29, 2023
@CbcWestwolf CbcWestwolf deleted the cherry-pick-42789-to-release-5.4 branch November 29, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@fzzf678 fzzf678 fzzf678 approved these changes

Assignees

@CbcWestwolf CbcWestwolf

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @CbcWestwolf @lcwangchao @fzzf678