BR: Support encryption for restored ebs volumes (#48900)#48938
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-7.5from Feb 7, 2024
Merged
Conversation
Signed-off-by: Naman Gupta <naman.gupta@gmail.com>
13 tasks
BornChanger
approved these changes
Feb 7, 2024
YuJuncen
approved these changes
Feb 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #48938 +/- ##
================================================
Coverage ? 71.9897%
================================================
Files ? 1403
Lines ? 406930
Branches ? 0
================================================
Hits ? 292948
Misses ? 94256
Partials ? 19726
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #48900
What problem does this PR solve?
Issue Number: close #48899
Problem Summary:
What changed and how does it work?
This PR adds a new flag "volume-encrypted". The flag sets the encrypted param, when creating the EBS volume. Default is disabled.
The flag will passed as an option to the backup_manager from the restore CRD, which sets it as a flag when invoking restore command.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.