planner: fix possible inconsistent output cols among union's children (#48775)#48896
Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-7.5from Feb 7, 2024
Merged
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #48896 +/- ##
================================================
Coverage ? 72.1396%
================================================
Files ? 1403
Lines ? 410278
Branches ? 0
================================================
Hits ? 295973
Misses ? 94623
Partials ? 19682
Flags with carried forward coverage won't be shown. Click here to find out more.
|
winoros
approved these changes
Feb 7, 2024
hawkingrei
approved these changes
Feb 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #48775
What problem does this PR solve?
Issue Number: close #48755
Problem Summary:
When UNIONALL's first child, it's possible that the selection is pushed at a position different with other children. This will cause inconsistent output columns among its children.
You can check the changed codes together with https://github.com/pingcap/tidb/blob/master/pkg/planner/core/rule_predicate_push_down.go#L479-L483 for more details.
And the failed case is something like
Proj{c1}->UnionAll{c1, c2, c3}->(Select{c2 > 0, c3 > 0}->Proj{c1, c2, c3}, Proj{c1, c2, c3}->Select{c2>0, c3>0}).UnionALL first only keeps the col
c1. But its first child's selection also requiresc2andc3, so the projection of its first children will keepc2andc3. The second child's projection doesn't need thec2andc3since the selection is pushed down.What is changed and how it works?
We use the UNIONALL's self output columns to do the alignment.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.