planner: fix possible inconsistent output cols among union's children (#48775)#48894
planner: fix possible inconsistent output cols among union's children (#48775)#48894ti-chi-bot wants to merge 1 commit intopingcap:release-6.5from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
too many conflicts |
This is an automated cherry-pick of #48775
What problem does this PR solve?
Issue Number: close #48755
Problem Summary:
When UNIONALL's first child, it's possible that the selection is pushed at a position different with other children. This will cause inconsistent output columns among its children.
You can check the changed codes together with https://github.com/pingcap/tidb/blob/master/pkg/planner/core/rule_predicate_push_down.go#L479-L483 for more details.
And the failed case is something like
Proj{c1}->UnionAll{c1, c2, c3}->(Select{c2 > 0, c3 > 0}->Proj{c1, c2, c3}, Proj{c1, c2, c3}->Select{c2>0, c3>0}).UnionALL first only keeps the col
c1. But its first child's selection also requiresc2andc3, so the projection of its first children will keepc2andc3. The second child's projection doesn't need thec2andc3since the selection is pushed down.What is changed and how it works?
We use the UNIONALL's self output columns to do the alignment.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.