Skip to content

ddl: fix issue of alter last partition failed when partition column is datetime (#48815)#48848

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-48815-to-release-7.5
Dec 5, 2023
Merged

ddl: fix issue of alter last partition failed when partition column is datetime (#48815)#48848
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-48815-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 23, 2023

This is an automated cherry-pick of #48815

What problem does this PR solve?

Issue Number: close #48814

Problem Summary: fix issue of alter last partition failed when partition column is datetime

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520 @ti-chi-bot
This is an automated cherry-pick of pingcap#48815
c886dee 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 23, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 23, 2023
Merged
13 tasks
@crazycs520
fix conflict
fabc4d4 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor

crazycs520 commented Nov 24, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-27 04:21:29.478535579 +0000 UTC m=+810118.143761774: ☑️ agreed by tiancaiamao.
  • 2023-11-27 04:21:43.033315788 +0000 UTC m=+810131.698541982: ☑️ agreed by wjhuang2016.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tiancaiamao, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 5, 2023
@crazycs520
Copy link
Contributor

crazycs520 commented Dec 5, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2023

@crazycs520: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 8c35443 into pingcap:release-7.5 Dec 5, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-48815-to-release-7.5 branch April 15, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@mjonss mjonss mjonss approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees

@crazycs520 crazycs520

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @crazycs520 @tiancaiamao @mjonss @wjhuang2016