Skip to content

br: add more retryable error for br_import (#48529)#48553

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5-20231113-v6.5.5from
Leavrth:hotfix-6569
Nov 13, 2023
Merged

br: add more retryable error for br_import (#48529)#48553
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5-20231113-v6.5.5from
Leavrth:hotfix-6569

Conversation

@Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Nov 13, 2023

This is an cherry-pick of #48529

What problem does this PR solve?

Issue Number: close #48528

Problem Summary:
the error need to be marked as the retryable error

What is changed and how it works?

add the error message into the retryable error list

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2023
@tiprow
Copy link

tiprow bot commented Nov 13, 2023

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 13, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Nov 13, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2023
@BornChanger
Copy link
Contributor

BornChanger commented Nov 13, 2023

/retest

@tiprow
Copy link

tiprow bot commented Nov 13, 2023

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor

BornChanger commented Nov 13, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 13, 2023
@codecov
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20231113-v6.5.5@71bcc44). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-6.5-20231113-v6.5.5     #48553   +/-   ##
================================================================
  Coverage                               ?   73.6872%           
================================================================
  Files                                  ?       1084           
  Lines                                  ?     348306           
  Branches                               ?          0           
================================================================
  Hits                                   ?     256657           
  Misses                                 ?      75192           
  Partials                               ?      16457

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-13 09:16:30.428587476 +0000 UTC m=+4067788.015697616: ☑️ agreed by BornChanger.
  • 2023-11-13 09:39:54.117959582 +0000 UTC m=+4069191.705069720: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot bot merged commit b26d746 into pingcap:release-6.5-20231113-v6.5.5 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer 3pointer approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees

No one assigned

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Leavrth @BornChanger @3pointer