Skip to content

br: add more retryable error for br_import (#48529)#48542

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-48529-to-release-6.5
Nov 24, 2023
Merged

br: add more retryable error for br_import (#48529)#48542
ti-chi-bot[bot] merged 2 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-48529-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 13, 2023

This is an automated cherry-pick of #48529

What problem does this PR solve?

Issue Number: close #48528

Problem Summary:
the error need to be marked as the retryable error

What is changed and how it works?

add the error message into the retryable error list

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#48529
8eb0baf 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 13, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 13, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 21, 2023
@Leavrth
resolve conflicts
7ff1436 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2023
@Leavrth
Copy link
Contributor

Leavrth commented Nov 23, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Nov 23, 2023

@Leavrth: No presubmit jobs available for pingcap/tidb@release-6.5

Details

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor

Leavrth commented Nov 23, 2023

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-23 11:33:17.23887712 +0000 UTC m=+490425.904103316: ☑️ agreed by BornChanger.
  • 2023-11-23 15:49:27.820615876 +0000 UTC m=+505796.485842071: ☑️ agreed by Leavrth.

@Leavrth
Copy link
Contributor

Leavrth commented Nov 23, 2023

/retest

1 similar comment
@Leavrth
Copy link
Contributor

Leavrth commented Nov 24, 2023

/retest

@codecov
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@cf8dbc2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #48542   +/-   ##
================================================
  Coverage               ?   73.6628%           
================================================
  Files                  ?       1086           
  Lines                  ?     349111           
  Branches               ?          0           
================================================
  Hits                   ?     257165           
  Misses                 ?      75457           
  Partials               ?      16489

@ti-chi-bot ti-chi-bot bot merged commit 71b9592 into pingcap:release-6.5 Nov 24, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-48529-to-release-6.5 branch April 15, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leavrth Leavrth Leavrth approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees

@Leavrth Leavrth

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @Leavrth @BornChanger