Skip to content

pkg: support the TSO format for asof expression (#48371)#48497

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5-20231109-v6.5.4from
BornChanger:release-6.5-20231109-v6.5.4
Nov 10, 2023
Merged

pkg: support the TSO format for asof expression (#48371)#48497
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5-20231109-v6.5.4from
BornChanger:release-6.5-20231109-v6.5.4

Conversation

@BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Nov 9, 2023 •
edited
Loading

close #48372

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2023
@tiprow
Copy link

tiprow bot commented Nov 9, 2023

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

BornChanger commented Nov 9, 2023

/cc @Defined2014 @cfzjywxk

@ti-chi-bot ti-chi-bot bot requested review from Defined2014 and cfzjywxk November 9, 2023 12:32
Defined2014
Defined2014 previously approved these changes Nov 9, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 9, 2023
cfzjywxk
cfzjywxk previously approved these changes Nov 9, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 9, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-09 12:38:39.71159697 +0000 UTC m=+3734317.298707115: ☑️ agreed by Defined2014.
  • 2023-11-09 13:19:42.429383469 +0000 UTC m=+3736780.016493613: ☑️ agreed by cfzjywxk.

@BornChanger
Copy link
Contributor Author

BornChanger commented Nov 9, 2023

/retest

@tiprow
Copy link

tiprow bot commented Nov 9, 2023

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger BornChanger dismissed stale reviews from cfzjywxk and Defined2014 via 76d4148 November 9, 2023 14:57
@BornChanger BornChanger force-pushed the release-6.5-20231109-v6.5.4 branch from fff62ab to 76d4148 Compare November 9, 2023 14:57
@ti-chi-bot ti-chi-bot bot removed the approved label Nov 9, 2023
@codecov
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20231109-v6.5.4@d7ce2f2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-6.5-20231109-v6.5.4     #48497   +/-   ##
================================================================
  Coverage                               ?   73.6672%           
================================================================
  Files                                  ?       1084           
  Lines                                  ?     348102           
  Branches                               ?          0           
================================================================
  Hits                                   ?     256437           
  Misses                                 ?      75207           
  Partials                               ?      16458

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit 1e8cf86 into pingcap:release-6.5-20231109-v6.5.4 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@Defined2014 Defined2014 Awaiting requested review from Defined2014

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BornChanger @cfzjywxk @Defined2014