copr: fix copr cache panic when tidb_enable_collect_execution_info is off (#48340)#48476
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-7.5from Jan 12, 2024
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
Signed-off-by: you06 <you1474600@gmail.com>
Defined2014
approved these changes
Nov 13, 2023
wshwsh12
approved these changes
Nov 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, wshwsh12 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #48476 +/- ##
================================================
Coverage ? 71.9834%
================================================
Files ? 1400
Lines ? 406603
Branches ? 0
================================================
Hits ? 292687
Misses ? 94227
Partials ? 19689
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #48340
What problem does this PR solve?
Issue Number: close #48212
Problem Summary:
Goroutine panic because of nil pointer dereference.
What is changed and how it works?
When coprocessor cache is hit, check the details before set execution info.
Because some internal tasks may lead to cache hit when
tidb_enable_collect_execution_infois turned off, so this need to be checked.Check List
Tests
It may panic like the log in #48212
No panic
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.