domain: add resolve lock logic for mvcc get key loading schema diff (#48330)#48415
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, ekexium The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/merge |
|
@cfzjywxk: We have migrated to builtin Please use
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/retest |
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #48415 +/- ##
================================================
Coverage ? 73.6103%
================================================
Files ? 1086
Lines ? 349277
Branches ? 0
================================================
Hits ? 257104
Misses ? 75688
Partials ? 16485 |
This is an automated cherry-pick of #48330
What problem does this PR solve?
Issue Number: close #48281 ref #47807
Problem Summary:
Handle lock error getting schema diff key using mvcc interfaces to avoid unexpected schema cache invalidation.
What is changed and how it works?
Check List
Tests
Running concurrent DDL with stale read requests with injected slow internal transaction commit, there's no
mvcc geterrors reported, the test result is in the description of this PRSide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.