Skip to content

planner: check nil pointer in rule_result_reorder to avoid panic (#48100)#48115

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-48100-to-release-6.5
Nov 24, 2023
Merged

planner: check nil pointer in rule_result_reorder to avoid panic (#48100)#48115
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-48100-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Oct 30, 2023

This is an automated cherry-pick of #48100

What problem does this PR solve?

Issue Number: close #45044

Problem Summary: planner: check nil pointer in rule_result_reorder to avoid panic

What is changed and how it works?

planner: check nil pointer in rule_result_reorder to avoid panic

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#48100
b6b0170 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Oct 30, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 30, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 2, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 24, 2023
@qw4990
Copy link
Contributor

qw4990 commented Nov 24, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Nov 24, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 24, 2023
@codecov
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@62766de). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #48115   +/-   ##
================================================
  Coverage               ?   73.6235%           
================================================
  Files                  ?       1086           
  Lines                  ?     349152           
  Branches               ?          0           
================================================
  Hits                   ?     257058           
  Misses                 ?      75600           
  Partials               ?      16494

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-24 04:27:15.833158066 +0000 UTC m=+551264.498384246: ☑️ agreed by hawkingrei.
  • 2023-11-24 05:19:18.115549355 +0000 UTC m=+554386.780775551: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit 7a8ae6e into pingcap:release-6.5 Nov 24, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-48100-to-release-6.5 branch April 15, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@0xPoe 0xPoe 0xPoe approved these changes

Assignees

@qw4990 qw4990

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @qw4990 @hawkingrei @0xPoe